Okay
  Public Ticket #3378096
Album Page
Closed

Comments

  • Menachem Hornbacher started the conversation

    I am having a few problems with the Album page

    1. The songs in the album are not loading

    I have tried both mp3 and wav files and on the homepage widget they work fine, however on the album page itself they fail to load

    2. The cover art cannot be changed

    There is an art on the top of some girl that I need to change to be the art of the album or at least of the actual artist. I have tried changing the file everywhere I can see one and this image will not change

    3. The Spotify and Apple music links don't show on either the homepage or the album page

    They exist in the album information

  • Menachem Hornbacher replied

    Hey Team. I found the bug causing #1 and would like to submit a fix if possible back to the theme.

    The issue is on line 62 of `single-albums.php` at the following function:

    echo wp_json_encode( $js_items );
    

    The problem with the above code is that, should a track name contain a `'` then it does not escape it causing the "data-player-items" to be invalid JSON breaking the player. I have fixed this on my site by adding the following option:

    echo wp_json_encode( $js_items, JSON_HEX_APOS );

    Please submit this upstream so that future updates do not break the site.

    #2 also seems to be being caused by the theme mod 'album_page_banner_image' never being set anywhere in the code. I think this is best solved by a larger update to use the featured image that I will work on and would like to contribute upstream as well.

    I updated this to use the previously un-used featured image on the post by changing line 3 of content-album.php to this:

    $featured_image_url = get_the_post_thumbnail_url(get_the_ID());
    

    as well as the CSS property to `background-image` rather than `background`

    #3 seems to make the buttons only show if there is some post-album text. I will also work on a fix for that and would like to submit it upstream as the checks here are probably wrong and would require more work to fix.

  •  839
    Jelly replied

    Hello,

    Thank you very much for sharing this with us! We are going to include this in the next release.

    Best Regards,
    Jelly Team